: selection: routing: promote terminals true and false (not just true) #508
+92
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78169907 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 11, 2025
pytorch-labs#508) Summary: it never came up before due to there being no surface syntax for `False` but terminal promotion should by symmetry be the same for `False` as exists for `True`. Differential Revision: D78169907
shayne-fletcher
force-pushed
the
export-D78169907
branch
from
47282a8 to
8228acf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78169907 |
shayne-fletcher
added a commit
to shayne-fletcher/monarch-1
that referenced
this pull request
Jul 11, 2025
pytorch-labs#508) Summary: it never came up before due to there being no surface syntax for `False` but terminal promotion should by symmetry be the same for `False` as exists for `True`. Differential Revision: D78169907
shayne-fletcher
force-pushed
the
export-D78169907
branch
from
8228acf to
c8b4882
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78169907 |
…ytorch-labs#507) Summary: handle 0d slices by canonically embedding them as 1d slices of extent 1, enabling uniform evaluation and routing logic. adds test coverage for `eval` and `next_steps`. Differential Revision: D78168758
pytorch-labs#508) Summary: it never came up before due to there being no surface syntax for `False` but terminal promotion should by symmetry be the same for `False` as exists for `True`. Differential Revision: D78169907
shayne-fletcher
force-pushed
the
export-D78169907
branch
from
c8b4882 to
500a255
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78169907 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: it never came up before due to there being no surface syntax for
Falsebut terminal promotion should by symmetry be the same forFalseas exists forTrue.Differential Revision: D78169907